Review Request 121071: Give undo notification a title
Kai Uwe Broulik
kde at privat.broulik.de
Mon Nov 10 09:30:03 UTC 2014
> On Nov. 10, 2014, 8:39 vorm., Marco Martin wrote:
> > better than nothing.. i think this is one of the cases it would be better to not have titles
Indeed, the notification would look super sleek without a title, however there might be broken (especially third party apps) apps and scripts that don't set a title and then you have no idea where it comes from. @Martin K: Any ideas? Or hack around by setting a space as title? dunno.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121071/#review70162
-----------------------------------------------------------
On Nov. 8, 2014, 6:19 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121071/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 6:19 nachm.)
>
>
> Review request for Plasma, Marco Martin and Martin Klapetek.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> The "Plasma" (default put in there by the notification applet because it has no title) is not really descriptive. It's a bit duplication now but better imho.
>
>
> Diffs
> -----
>
> src/plasma/private/applet_p.cpp a4f7c1c
>
> Diff: https://git.reviewboard.kde.org/r/121071/diff/
>
>
> Testing
> -------
>
> Deleted a widget and a panel.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141110/aa0c5924/attachment-0001.html>
More information about the Plasma-devel
mailing list