Review Request 121085: Migrate ProgressBar to QtQuick.Controls

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121085/#review70165
-----------------------------------------------------------

Ship it!


good to go after the notes you already taken (like removing orientation checks)


src/declarativeimports/plasmacomponents/qml/styles/ProgressBarStyle.qml
<https://git.reviewboard.kde.org/r/121085/#comment49082>

    control.indeterminate && control.visible, just to be sure it doesn't run in vain


- Marco Martin


On Nov. 9, 2014, 4:18 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121085/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2014, 4:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This also fixes a regression introduced in 7a5342e97067cffb316fd57e20f1ca326a0854ee where the devicePixelRatio was no longer taken into account.
> 
> The test is enhanced to also cover vertical bars. The QtQuick.Controls ProgressBar just rotates the progress bar by 90° when vertical so I could remove a lot of the (vertical ? foo : bar) everywhere.
> 
> I tried to migrate the indeterminate animation to Animators but after thinking about adding timers and having a dozen of bindings to reset the animation I stopped.
> 
> 
> Diffs
> -----
> 
>   tests/components/progressbar.qml 7098650 
>   src/declarativeimports/plasmacomponents/qml/styles/ProgressBarStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/ProgressBar.qml 69b6df1 
> 
> Diff: https://git.reviewboard.kde.org/r/121085/diff/
> 
> 
> Testing
> -------
> 
> Battery monitor looks like it did before, used the progressbar test to spot regressions.
> 
> The only regression I found was that
> minimumValue: -100
> maximumValue: 100
> value: 0
> yields an empty 0% bar instead, value: 50 a 50%, seems minimumValue cannot go below 0?
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141110/1f085f38/attachment.html>