Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.
Luca Beltrame
lbeltrame at kde.org
Sat Nov 8 08:21:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/#review70027
-----------------------------------------------------------
Looks fairly OK to me but "inScriptSupportedDir" is kind of awkward to me. However I don't have any better suggestion for now.
- Luca Beltrame
On Nov. 8, 2014, 3:09 a.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121058/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 3:09 a.m.)
>
>
> Review request for Plasma and Luca Beltrame.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> KLauncher doesn't start these, so we shouldn't list them.
>
>
> Diffs
> -----
>
> kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006
>
> Diff: https://git.reviewboard.kde.org/r/121058/diff/
>
>
> Testing
> -------
>
> an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the kcm here anymore.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141108/61e4c16a/attachment-0001.html>
More information about the Plasma-devel
mailing list