Review Request 121058: Don't put scripts from ~/.config/autostart in autostart kcm list.
Thomas Lübking
thomas.luebking at gmail.com
Fri Nov 7 22:34:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121058/#review70020
-----------------------------------------------------------
kcms/autostart/autostart.cpp
<https://git.reviewboard.kde.org/r/121058/#comment48975>
I don't want to be annoyin, but "isAutostart" in "Autostart::load()" and below "autostartdir" is probably suboptimal ;-)
"requiresServiceFile" or similar?
- Thomas Lübking
On Nov. 7, 2014, 10:31 nachm., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121058/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 10:31 nachm.)
>
>
> Review request for Plasma and Luca Beltrame.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> KLauncher doesn't start these, so we shouldn't list them.
>
>
> Diffs
> -----
>
> kcms/autostart/autostart.cpp 8fe81ad7fc752936cd8ba1c799ad06bafd2c4006
>
> Diff: https://git.reviewboard.kde.org/r/121058/diff/
>
>
> Testing
> -------
>
> an executable script (ssh-add.sh) in ~/.config/autostart/ doesn't appear in the kcm here anymore.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141107/d46f0815/attachment-0001.html>
More information about the Plasma-devel
mailing list