Review Request 121033: Mark LibKWorkspace and ScreenSaverDBusInterface as REQUIRED

Aleix Pol Gonzalez aleixpol at kde.org
Fri Nov 7 15:45:29 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121033/#review70008
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Nov. 7, 2014, 2:49 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121033/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2014, 2:49 p.m.)
> 
> 
> Review request for Plasma, Àlex Fiestas and Aleix Pol Gonzalez.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Other parts of the build system assume these have been found, so
> configuring fails when they are missing.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ebf0bff6f3aaefe5b969b033502749bddf781995 
> 
> Diff: https://git.reviewboard.kde.org/r/121033/diff/
> 
> 
> Testing
> -------
> 
> Configure errors out with a more relevant message (about not finding LibKWorkspace) when plasma-workspace is not installed. When plasma-workspace is installed, LibKWorkspace and ScreenSaverDBusInterface are correctly listed under the REQUIRED modules, and configuring (and building) is successful.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141107/d726efc5/attachment.html>


More information about the Plasma-devel mailing list