Review Request 121013: Plasmate-Kdev: Add plasma project manager

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121013/#review69976
-----------------------------------------------------------

Ship it!


Looks good, some minor stuff below.


plasmate/plugins/plasmaprojectmanager/plasmaitem.cpp
<https://git.reviewboard.kde.org/r/121013/#comment48965>

    itemText instead of textItem?



plasmate/plugins/plasmaprojectmanager/plasmaitem.cpp
<https://git.reviewboard.kde.org/r/121013/#comment48964>

    minor: itemText instead of textItem?



plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.cpp
<https://git.reviewboard.kde.org/r/121013/#comment48963>

    I think this and the following headers can be removed.


- Sebastian Kügler


On Nov. 6, 2014, 4:04 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121013/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 4:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> Plasma Project Manager offers a custom view for plasma packages.
> If a file or a directory matches the entries from the plasma package
> then instead of using the real name of the file or directory it will use
> the semantic one.
> 
> 
> Diffs
> -----
> 
>   plasmate/plugins/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/plasmaprojectmanager/CMakeLists.txt PRE-CREATION 
>   plasmate/plugins/plasmaprojectmanager/kdevplasmamanager.desktop.cmake PRE-CREATION 
>   plasmate/plugins/plasmaprojectmanager/plasmaitem.h PRE-CREATION 
>   plasmate/plugins/plasmaprojectmanager/plasmaitem.cpp PRE-CREATION 
>   plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.h PRE-CREATION 
>   plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121013/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141107/83ed684d/attachment-0001.html>