Review Request 121016: [RFC] Make it possible to make plasmawindow live in a status notifier

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121016/#review69975
-----------------------------------------------------------

Ship it!


Really cool idea! Some niggles inline.


plasma-windowed/main.cpp
<https://git.reviewboard.kde.org/r/121016/#comment48960>

    --statusnotifier perhaps? That would be consistent with the naming in the code.



plasma-windowed/plasmawindowedview.cpp
<https://git.reviewboard.kde.org/r/121016/#comment48961>

    Maybe also 0 for consistency? Using 0 and nullptr on consecutive lines makes one wonder, otherwise.



plasma-windowed/plasmawindowedview.cpp
<https://git.reviewboard.kde.org/r/121016/#comment48962>

    I wonder if the background here should be transparant?


- Sebastian Kügler


On Nov. 6, 2014, 6:55 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121016/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 6:55 p.m.)
> 
> 
> Review request for kdeconnect and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [background explaination]
> I was thinking yesterday about the problem KDE Connect has that it's not really usable in any non-Plasma workspace because the main interface is the plasmoid.
> I understand that this won't solve all problems, but it can be a first approach for making plasmoids less of a niche solution, making it possible to let the solutions we have currently available elsewhere (it's especially interesting considering that most of our useful plasmoids live on the panel).
> The end goal is that KDE Connect can provide a desktop file with NotShowIn=KDE that lauches the plasmoid in a status notifier.
> [End of background explaination]
> 
> Now this introduces a --systray argument (can be changed, I couldn't find a better name) that sets up a status notifier item and when the window is closed it doesn't kill the process. It's quite straightforward, but needs polishing I guess.
> 
> 
> Diffs
> -----
> 
>   plasma-windowed/CMakeLists.txt 252724a 
>   plasma-windowed/main.cpp 649bd39 
>   plasma-windowed/plasmawindowedcorona.h 8e6fd76 
>   plasma-windowed/plasmawindowedcorona.cpp 849fa51 
>   plasma-windowed/plasmawindowedview.h a6a8a44 
>   plasma-windowed/plasmawindowedview.cpp 4e0ac65 
> 
> Diff: https://git.reviewboard.kde.org/r/121016/diff/
> 
> 
> Testing
> -------
> 
> Played around with it for a while.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141107/ea13d01d/attachment.html>