Review Request 120542: Plasmate-Kdev: Add packagemanagerview

[Giorgos Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120542/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 6:04 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasmate


Description
-------

This is the new version of our package viewer.

The technical differences between the new and the old one are:
* the old one was a QDockWidget which was hardcoded inside plasmate
  the new one is a KDevPlatform plugin
* the new one requires less code because we reuse KDevelop::ProjectModel

Visually I tried to avoid any changes. The only visual difference is that
we are missing the "New.." entries.

The screenshots show the new package viewer.

Commits

------------------------------------------------------------------------
    Cleanup the packagehandler, plasmoidhandler and themehandler
    
    We will use KDevelop::PackageModel which is a QAIM with its own
    info so we don't need our nodes. What we need is a a way
    (PackageModel::description) which will associate for example
    the filename "main.qml" to "Mainscript".

------------------------------------------------------------------------
    Add the packagemanagerview plugin
    
    This is a plugin which shows the files of the package according to the
    package structure. We reuse the KDevelop::ProjectModel as our model and we
    just proxy it by using QIDentityProxyModel.
------------------------------------------------------------------------


Diffs
-----

  plasmate/tests/themehandlertest.h a080d14 
  plasmate/tests/themehandlertest.cpp 42dab7b 
  plasmate/plugins/packagemanagerview/packagemanagerview.cpp PRE-CREATION 
  plasmate/plugins/packagemanagerview/packagemanagerviewplugin.h PRE-CREATION 
  plasmate/plugins/packagemanagerview/packagemanagerviewplugin.cpp PRE-CREATION 
  plasmate/plugins/packagemanagerview/proxymodel.h PRE-CREATION 
  plasmate/plugins/packagemanagerview/proxymodel.cpp PRE-CREATION 
  plasmate/tests/plasmoidhandlertest.h e888c53 
  plasmate/tests/plasmoidhandlertest.cpp a6abc98 
  plasmate/CMakeLists.txt 3380f82 
  plasmate/packagehandler/packagehandler.h 7dbc3bb 
  plasmate/packagehandler/packagehandler.cpp ead1f37 
  plasmate/packagehandler/plasmoidhandler.h 11ca4ae 
  plasmate/packagehandler/plasmoidhandler.cpp 60009c9 
  plasmate/packagehandler/themehandler.h 6c95d83 
  plasmate/packagehandler/themehandler.cpp 4d88361 
  plasmate/plugins/CMakeLists.txt PRE-CREATION 
  plasmate/plugins/packagemanagerview/CMakeLists.txt PRE-CREATION 
  plasmate/plugins/packagemanagerview/Messages.sh PRE-CREATION 
  plasmate/plugins/packagemanagerview/kdevpackagemanagerview.desktop.cmake PRE-CREATION 
  plasmate/plugins/packagemanagerview/kdevpackagemanagerview.rc PRE-CREATION 
  plasmate/plugins/packagemanagerview/packagemanagerview.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120542/diff/


Testing
-------


File Attachments
----------------

theme package
  https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/a4995d07-5564-41c5-a1f7-2cf39e5cd13f__packagemanagerview_theme.png
plasmoid package
  https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/0bc938b4-495e-4df9-bdf9-4780f12619e9__packagemanagerview_plasmoid2.png


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141106/7de5a543/attachment.html>