Review Request 121010: Keep track of notifications that were covered by a fullscreen window

[Martin Gräßlin]

> On Nov. 6, 2014, 1:12 p.m., Martin Gräßlin wrote:
> > applets/notifications/plugin/notificationshelper.cpp, lines 169-173
> > <https://git.reviewboard.kde.org/r/121010/diff/1/?file=326319#file326319line169>
> >
> >     note: this code causes roundtrips to the X server. At the same time it's information already known to the plasmashell process: tasks dataengine.
> >     
> >     It might be worth to have a look at it, whether this could be used instead.
> 
> Kai Uwe Broulik wrote:
>     Thanks for the suggestion! I already wondered this call might be heavy.
>     
>     So, connecting to the tasks dataengine, iterating over all tasks and checking whether active and fullScreen is true should work.
> 
> Eike Hein wrote:
>     Only when the tasks dataengine is being used though - keep in mind the Task Manager applet doesn't use it. A standard user session doesn't have the data engine loaded. It might still be the right thing to avoid redundancy, but not sure what the best common case tradeoff is.

thanks Eike, that's a good point. Is there something which could be shared from libtaskmanager?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121010/#review69935
-----------------------------------------------------------


On Nov. 6, 2014, 12:47 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121010/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 12:47 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch improves fullscreen handling in notifications.
> 
> The type of the NotificationPopup is changed to Dialog.Notification because that's what it's for, I think there's been a bit of a miscommunication about that (I think there needs to be another layer for the OSD because that one should be above all..).
> The Notification type keeps the window above (sorta fixing Bug 338946 because the close button now works as expected now) everything but not a fullscreen window if it's active. This patch checks when a notification arrives whether the active window is fullscreen (concealing the notification) and adds it to the history. To indicate that you missed notifications while you were fullscreen, the icon glows blue (until you interact with a notification or open the plasmoid).
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationIcon.qml 1449c19 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 212f1e6 
>   applets/notifications/package/contents/ui/Notifications.qml acdccdd 
>   applets/notifications/package/contents/ui/main.qml 3c2fa13 
>   applets/notifications/plugin/notificationshelper.h af8f6fa 
>   applets/notifications/plugin/notificationshelper.cpp 425f0d6 
> 
> Diff: https://git.reviewboard.kde.org/r/121010/diff/
> 
> 
> Testing
> -------
> 
> Fullscreened my IDE, "sleep 2; knotificationdbustest", waited, unfullscreened, icon was blue and the history a few notifications in it.
> 
> 
> File Attachments
> ----------------
> 
> Pending notification in tray
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/06/3f2141b2-1452-4e5c-8b00-782c571ad34b__notificationpendingthing.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141106/18007aa3/attachment.html>