Review Request 121006: Bring back Notifications applet settings

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121006/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 11:29 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
-------

This adds back the configuration UI for configuring whether it shows notifications and/or jobs. The infrastructure has all been there thankfully and I just tweaked it and added a UI.


Diffs
-----

  applets/notifications/package/contents/config/config.qml PRE-CREATION 
  applets/notifications/package/contents/config/main.xml 399159d 
  applets/notifications/package/contents/ui/configNotifications.qml PRE-CREATION 
  applets/notifications/package/contents/ui/main.qml 3c2fa13 

Diff: https://git.reviewboard.kde.org/r/121006/diff/


Testing
-------

Turned off notifications, kdialog opened a fallback popup.
Turned off jobs, nothing happened. For some reason it did not fall back to the legacy progress dialog. :/ Probably because the kuiserver stuff is built-in into plasma unconditionally?


File Attachments
----------------

Notification settings
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/05/31f2129f-7853-4c5c-9365-8e9f657b10cc__notificationsconfig.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141106/2cb8857f/attachment.html>