Review Request 120936: [KInfoCenter] Set the correct version

Martin Gräßlin mgraesslin at kde.org
Thu Nov 6 07:39:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120936/#review69923
-----------------------------------------------------------

Ship it!



Modules/infosummary/infosum.cpp
<https://git.reviewboard.kde.org/r/120936/#comment48916>

    shouldn't it be <config-workspace.h>?


- Martin Gräßlin


On Nov. 6, 2014, 1 vorm., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120936/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 1 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> bonus - dropped dep on plasma-framework
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b30a581 
>   Modules/infosummary/CMakeLists.txt 5ae1faf 
>   Modules/infosummary/infosum.cpp 7330036 
>   config-workspace.h.cmake 66c1d63 
> 
> Diff: https://git.reviewboard.kde.org/r/120936/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141106/06753bd5/attachment.html>


More information about the Plasma-devel mailing list