Review Request 121002: Add a small utility to sync kde5 config's back into kde4 settings + backport component chooser settings

Aleix Pol Gonzalez aleixpol at kde.org
Wed Nov 5 18:47:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121002/#review69911
-----------------------------------------------------------

Ship it!


Looks good! Maybe you can port the similar code to this?

- Aleix Pol Gonzalez


On Nov. 5, 2014, 3:02 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121002/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2014, 3:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Backport settings made in the component chooser to KDE 4 applications
> 
> BUG: 339967
> 
> 
> Add a small utility to sync kde5 config's back into kde4 settings
> 
> I dont' think it needs to be in frameworks, as the only user of
> backporting settings will be the plasma kcms, but it's code that's
> duplicated across these KCMS at the moment
> 
> 
> Diffs
> -----
> 
>   kcms/migrationlib/kdelibs4config.h PRE-CREATION 
>   kcms/componentchooser/componentchooserbrowser.cpp 61af1fd 
>   kcms/componentchooser/componentchooserfilemanager.cpp b23bfa0 
>   kcms/componentchooser/componentchooserterminal.cpp 05673c6 
> 
> Diff: https://git.reviewboard.kde.org/r/121002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141105/6f6add28/attachment.html>


More information about the Plasma-devel mailing list