Review Request 120997: Add timestamp to notification history

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120997/
-----------------------------------------------------------

(Updated Nov. 5, 2014, 6:10 nachm.)


Review request for Plasma, KDE Usability and Martin Klapetek.


Changes
-------

Add "yesterday" and "n days ago"

Until 23 hours it will show the time (so it is immediately obvious "hour larger then current time, must be yesterday"), then it shows "Yesterday" until 00:00 and then "n days ago".


Repository: plasma-workspace


Description
-------

This simple patch shows the time when a notification was added to the history.

Of course would be fancy to have "1min ago", "5min ago" etc but that's much more complicated since we cannot listen to changes of a Date() object but would need to pull in the dataengine and then we get timezone sync issues and what not. So this just stores a Date() object and displays it as hours.


Diffs (updated)
-----

  applets/notifications/package/contents/ui/NotificationDelegate.qml 75bcfd5 
  applets/notifications/package/contents/ui/NotificationItem.qml 724cc13 
  applets/notifications/package/contents/ui/Notifications.qml acdccdd 

Diff: https://git.reviewboard.kde.org/r/120997/diff/


Testing
-------

Pretty nifty! The looks could be improved a bit I guess.


File Attachments
----------------

Notification history with timestamp
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/20f3c850-0f64-4807-bbde-064bf730d830__notificationtimestamp.png
Multiple notifications with relative time
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/04/f4979255-2971-4458-bf2c-ec05819591e5__notificationtimestamp1.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141105/034a0d3d/attachment-0001.html>