Review Request 121004: Fix logout: Remove uneeded code to stop alt+f4 killing the window
Bhushan Shah
bhush94 at gmail.com
Wed Nov 5 17:10:28 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121004/#review69901
-----------------------------------------------------------
Related to https://bugs.kde.org/show_bug.cgi?id=338360 ?
- Bhushan Shah
On Nov. 5, 2014, 10:20 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121004/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2014, 10:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Remove uneeded code to stop alt+f4 killing the window
>
> This fixes ksmserver not being able to logout or shutdown correctly as
> it was unable to kill Plasma.
>
> Tests showed that pressing alt+f4 no longer kills the window anyway
> (possibly a change in kwin or Qt?)
>
>
> Diffs
> -----
>
> shell/desktopview.cpp adf405f
>
> Diff: https://git.reviewboard.kde.org/r/121004/diff/
>
>
> Testing
> -------
>
> Previously I could not log out with:
> qdbus org.kde.ksmserver /KSMServer org.kde.KSMServerInterface.logout 0 0 0
>
> with this patch I can.
>
> Pressed alt+f4 when desktop + panels were the only window. Nothing seemed to happen.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141105/fd4bef44/attachment.html>
More information about the Plasma-devel
mailing list