Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120943/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 7:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
-------

This moves duplicate code (notification icon, heading, text, action buttons) into a separate NotificationItem {} component used by both the notification popup as well as the notification list delegate.

If we ever were to provide richer notifications for specific usecases (you can provide custom hints in notifications after all) this would ease this and less duplication is always good :)

I also cleaned up a bit of commented/unused code and changed complicated anchoring to QtQuick Layouts where applicable.


Diffs
-----

  applets/notifications/package/contents/ui/NotificationDelegate.qml 88f6cd2 
  applets/notifications/package/contents/ui/NotificationItem.qml PRE-CREATION 
  applets/notifications/package/contents/ui/NotificationPopup.qml 26c7ed2 

Diff: https://git.reviewboard.kde.org/r/120943/diff/


Testing
-------

Ran knotificationdbustest and didn't notice anything unusual, visually the thing should look and behave exactly like it did before. Additional testing is welcomed, however.


File Attachments
----------------

New popup
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/02/9b20416e-a4c6-4694-aff3-bdad26cf3206__newnotificationpopup.png
New history
  https://git.reviewboard.kde.org/media/uploaded/files/2014/11/03/e7efdf8f-09de-4eaf-a7a2-d37979bad28b__newnotificationhistory.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141104/87a1a7dc/attachment-0001.html>