Review Request 120957: Oxygen: Sync advanced settings to KDE4

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120957/#review69802
-----------------------------------------------------------


what about dependencies ? Are we happy with oxygen KF5 style always depending on Kdelibs4Migration ? (I don't know which framework it belongs to).
Since the diff has no change in CMakeLists, I guess it must already be in the (at least indirect) dependencies. Any idea wherefrom ? And finally, should we try make this dependency 'optional' at compile time ?

- Hugo Pereira Da Costa


On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120957/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 2:24 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> Sync advanced settings to KDE4
> 
> 
> Diffs
> -----
> 
>   kstyle/config/oxygenstyleconfig.cpp 8185910 
> 
> Diff: https://git.reviewboard.kde.org/r/120957/diff/
> 
> 
> Testing
> -------
> 
> Copies data correctly.
> 
> Oxygen KDE4 apps update after reload. 
> They don't update immediately but that bug is unrelated as that isn't happening when running "kcmshell4 style"
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141104/784f23c5/attachment-0001.html>