Review Request 120970: Remove combo "Graphical Effects"
Martin Klapetek
martin.klapetek at gmail.com
Tue Nov 4 11:56:41 UTC 2014
> On Nov. 4, 2014, 11:59 a.m., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in Oxygen/Breeze?
>
> David Edmundson wrote:
> Turns out that was a very good question.
>
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
>
> So we were using this config entry, but writing it as an integer and reading it as a boolean. So it was animated for everything, except: "Low display resolution and Low CPU"
>
> Martin Gräßlin wrote:
> Personal opinion: this shouldn't be on any config option at all. If at all the animation setting should get derived from the hardware. If a style wants to expose an option that's fine, but it should be in the style specific config..
>
> Kai Uwe Broulik wrote:
> Deduced from the hardware (and "is remote session") is certainly nice but difficult, no?
> Also, what about Plasma's animations? We do use units.{long,short}Duration everywhere but can this be disabled somewhere or what settings does that follow?
> We do use units.{long,short}Duration everywhere but can this be disabled somewhere or what settings does that follow?
Look&Feel package, iirc.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
-----------------------------------------------------------
On Nov. 4, 2014, 11:55 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 11:55 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Remove combo "Graphical Effects"
>
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
>
>
> Diffs
> -----
>
> kcms/style/finetuning.ui 3abb692
> kcms/style/kcmstyle.cpp 6585ee6
>
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141104/dca1e56b/attachment.html>
More information about the Plasma-devel
mailing list