Review Request 120965: Base panelcontroller and more settings menu on button sizes

Kai Uwe Broulik kde at privat.broulik.de
Tue Nov 4 09:25:53 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120965/#review69784
-----------------------------------------------------------



desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml
<https://git.reviewboard.kde.org/r/120965/#comment48859>

    Should probably also take these headings into account


- Kai Uwe Broulik


On Nov. 3, 2014, 10:44 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120965/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2014, 10:44 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Not every language has short fancy expressions for things and thus stuff breaks when using it in German, for example the "Windows can cover" or "Add spacer" button were cut off. This fixes this by accounting the button widths in the minimum width.
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml 2ab662c 
>   desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 7cf567e 
> 
> Diff: https://git.reviewboard.kde.org/r/120965/diff/
> 
> 
> Testing
> -------
> 
> No more cut off buttons, but it seems there's an issue with re-layouting when dragging a horizontal to a side.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141104/ee806d7e/attachment.html>


More information about the Plasma-devel mailing list