Review Request 120961: Use Loader for "More Settings" menu in panelcontroller
Kai Uwe Broulik
kde at privat.broulik.de
Mon Nov 3 20:47:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120961/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-desktop
Description
-------
Panelcontroller already takes quite some time to load, so we should not load the "More Settings" menu if it is not opened.
I usually only open the panelcontroller to quickly remove an applet I accidentally added to my panel, I hardly ever use the settings menu.
That import org.kde.plasma.configuration 2.0 looks unused to me.
Diffs
-----
desktoppackage/contents/configuration/panelconfiguration/MoreSettingsMenu.qml PRE-CREATION
desktoppackage/contents/configuration/panelconfiguration/Ruler.qml c4c2ed3
desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml 828147c
Diff: https://git.reviewboard.kde.org/r/120961/diff/
Testing
-------
There's still a noticeable delay but it's less than before though I hoped that patch helped more significantly. Other than that works as expected.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141103/c8a7be82/attachment.html>
More information about the Plasma-devel
mailing list