Review Request 120913: [kcms/lnf] Make a list variable const
Martin Gräßlin
mgraesslin at kde.org
Mon Nov 3 08:45:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120913/
-----------------------------------------------------------
(Updated Nov. 3, 2014, 8:45 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-desktop
Description
-------
The dataPath variable is used in an extended for-loop as of C++11.
As the variable was not const the for loop uses the more expensive
iterators which allow modification of the list. By making the list
const it can use the better const iterator.
See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/
Diffs
-----
kcms/lookandfeel/kcm.cpp a46774200c0c378485a474ff538294c7617ef6d2
Diff: https://git.reviewboard.kde.org/r/120913/diff/
Testing
-------
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141103/1d486191/attachment.html>
More information about the Plasma-devel
mailing list