Review Request 120936: [KInfoCenter] Set the correct version

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120936/#review69703
-----------------------------------------------------------



Modules/infosummary/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120936/#comment48823>

    kinfocenter has config-foo.h.cmake files. Thus I'd suggest to define it there and not use command line switch for it.


- Martin Gräßlin


On Nov. 1, 2014, 7:48 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120936/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2014, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> bonus - dropped dep on plasma-framework
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6c1dd1d 
>   Modules/infosummary/CMakeLists.txt 5ae1faf 
>   Modules/infosummary/infosum.cpp e58beb0 
> 
> Diff: https://git.reviewboard.kde.org/r/120936/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141103/84b45826/attachment.html>