Review Request 120855: Add Google two-step verification support to PMC Picasa login
Shantanu Tushar
shantanu at kde.org
Mon Nov 3 03:48:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120855/#review69698
-----------------------------------------------------------
Thanks for your time on this, good stuff :) Tried it and the only caveat is that after login is done I have to press the back button (the one on the pmc controller) to get my album list. That should be fixed.
browsingbackends/onlineservices/picasa/picasamodel.h
<https://git.reviewboard.kde.org/r/120855/#comment48822>
where do you get these from?
- Shantanu Tushar
On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120855/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2014, 3:34 p.m.)
>
>
> Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Bugs: 336398
> http://bugs.kde.org/show_bug.cgi?id=336398
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Changed auth method from Client Login to OAuth using libkgapi2
>
>
> Diffs
> -----
>
> browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d
> browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7
> browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240
> browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7
> browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310
> browsingbackends/onlineservices/picasa/picasamodel.h 5bce055
> browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156
>
> Diff: https://git.reviewboard.kde.org/r/120855/diff/
>
>
> Testing
> -------
>
> Everything is working fine except that after successful login, user has to press back to view all the albums.
>
>
> Thanks,
>
> Ashish Bansal
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141103/9cca3824/attachment.html>
More information about the Plasma-devel
mailing list