Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.

[Ivan Čukić]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118340/#review58867
-----------------------------------------------------------

Ship it!


I don't have anything against the patch, except that it is a bit different to what the kf5 version (master) has.

Master checks for the option called KACTIVITIES_LIBRARY_ONLY.

If it is not a bother, can you rename the option in 4.13 to match it - to avoid confusion.

- Ivan Čukić


On May 31, 2014, 3:42 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118340/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 3:42 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled.
> 
> I'm not sure if this is the best way to do this.  If there is any better way, I'll update the patch as appropriate.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 
> 
> Diff: https://git.reviewboard.kde.org/r/118340/diff/
> 
> 
> Testing
> -------
> 
> Visually inspected install directories.  Seems to remove only what is necessary.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140531/3be6a00e/attachment.html>