Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available
Marco Martin
notmart at gmail.com
Fri May 30 12:10:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118419/#review58795
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Martin
On May 30, 2014, 12:01 p.m., Eike Hein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118419/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 12:01 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author.
>
> A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components.
>
>
> Diffs
> -----
>
> wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml c139941
> wallpapers/image/imagepackage/contents/ui/config.qml 9f1602b
>
> Diff: https://git.reviewboard.kde.org/r/118419/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Example tooltip
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/f7c261cf-c0ea-4850-ab3b-04ef885627b3__tooltip.png
>
>
> Thanks,
>
> Eike Hein
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140530/a713d7e8/attachment.html>
More information about the Plasma-devel
mailing list