Review Request 118390: Powerdevil KCM Updates

Thu May 29 16:10:19 UTC 2014

> On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote:
> > Good improvements in general!
> > There are two changes which are not HIG-compliant:
> > - Control labels which are written next to the controls (checkboxes, spin boxes etc.) do not use Title Capitalization. See http://techbase.kde.org/Projects/Usability/HIG/Capitalization for details. Therefore most of the capitalization changes have to be reverted, I'm afraid.
> > - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing
> > Apart from those two things, the changes look fine to me!

> - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing

Hmm, may be time to update that portion of the HIG since, from a visual design standpoint, spacing can be quite effective at grouping visual elements while avoiding more visual "chrome". In this case, for the Advanced page, a bit more spacing between the Battery Levels group and the Events group should provide enough visual distinction between the groups. Also, the checkboxes in the Events group can probably be left-aligned under Events since they're unrelated to the widgets from the Battery Levels group and likely better match the alignment guidelines for making the checkboxes span two columns (http://techbase.kde.org/Projects/Usability/HIG/Alignment).

Otherwise, the changes look quite nice to me!

- Andrew

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58692
-----------------------------------------------------------

On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 11:33 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -----
> 
>   kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 
>   kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 
>   kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 
>   kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e 
>   kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 
>   kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 
>   kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 
>   kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 
>   kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935994e4a5a08fd7da6ceb95ba7b726ac708 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc 
> 
> Diff: https://git.reviewboard.kde.org/r/118390/diff/
> 
> 
> Testing
> -------
> 
> Tested in kcmshell5 and systemsettings, still fully functional.
> 
> 
> File Attachments
> ----------------
> 
> Energy Saving page before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
> Energy Saving page after
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
> Advanced page after
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
> Advanced page before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140529/3ad1c19b/attachment.html>