Review Request 118251: Small improvments to FadingNode and IconItem

[David Edmundson]

> On May 22, 2014, 10:02 a.m., David Edmundson wrote:
> > src/declarativeimports/core/fadingnode.cpp, line 87
> > <https://git.reviewboard.kde.org/r/118251/diff/1/?file=274043#file274043line87>
> >
> >     Now it will animate backwards?
> >     
> >     Unless you change the vertex shader too.
> 
> Martin Gräßlin wrote:
>     this is really confusing. Why is there a check on target changed and then source gets bound? I might have gotten that wrong but it looked strange. Could you please elaborate on how that's supposed to work?
> 
> David Edmundson wrote:
>     Oooh! You're right. Clearly something is off.
>     
>     I think we might have to then swap round tex1 and tex2 in this line:
>     gl_FragColor.a = mix(tex1.a, tex2.a, 
>     
>     before submitting could you try it on a super slow animation and check it still animates correctly
> 
> Martin Gräßlin wrote:
>     no, I cannot animate at all, see https://bugreports.qt-project.org/browse/QTBUG-39182

I tested this, you do need to swap round tex1 and text2 in my mix line in the shader.

You can either do that and ship it, or I can ship for yoU?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review58275
-----------------------------------------------------------


On May 22, 2014, 6:02 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118251/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 6:02 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Small improvments to FadingNode and IconItem
> 
> * trigger an update after the animation finished as the IconItem needs to
>   switch to SVGTextureNode again
> * Don't connect needlessly to a lambda slot
> * FadingMaterialShader had the texture bind swapped
> * Fix virtual method hidden warning in FadingMaterialShader
> * Use dynamic_cast instead of static_cast to convert to SVGTextureNode
>   or FadingNode.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/fadingnode.cpp 207eff3902848a3c76bf1ec62d73877d6d9d0df7 
>   src/declarativeimports/core/iconitem.cpp bdf5e286c9bff3ebd0b124f1593de63ed4232515 
> 
> Diff: https://git.reviewboard.kde.org/r/118251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140529/b9850017/attachment.html>