Review Request 118073: Use QHostInfo in kio_nfs
David Edmundson
david at davidedmundson.co.uk
Thu May 29 15:06:02 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118073/#review58735
-----------------------------------------------------------
Ship it!
nfs/kio_nfs.cpp
<https://git.reviewboard.kde.org/r/118073/#comment40860>
I don't think so.
Read qhostinfo_unix.cpp localDomainName
it has all sorts of fallbacks.
- David Edmundson
On May 10, 2014, 2:42 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118073/
> -----------------------------------------------------------
>
> (Updated May 10, 2014, 2:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Use QHostInfo in kio_nfs
>
>
> Diffs
> -----
>
> nfs/CMakeLists.txt dfc6eae3fad51eee0e736970da9520959eeed1f5
> nfs/kio_nfs.cpp 293df2529a2488b7970dbe81a5ec202bc6a22742
>
> Diff: https://git.reviewboard.kde.org/r/118073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140529/f5b95271/attachment-0001.html>
More information about the Plasma-devel
mailing list