Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

[David Edmundson]

> On May 29, 2014, 2:30 p.m., David Edmundson wrote:
> > >Unfortunately this way we cannot have a plural aware suffix.
> > 
> > Then why port away?
> > Linking against kde4libsupport seems like the lesser of two evils.
> 
> Aleix Pol Gonzalez wrote:
>     Well then we need to decide how we're going to get to the proper fix. We can't just decide it's good enough to depend on kdelibs4.

We also can't just break things.

Options are:
 1) restore KIntSpinBox to kwidgetaddons
 2) fix Qt, and drop the lib dependency once we have 5.4

I was just looking at Qt translator code. Detecting if something is singular or plural is not an easy task, and you need to have the locale tell you. There's not a nice system that fits in with Qt's API. I guess we can file a bug report anyway and see what happens.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58724
-----------------------------------------------------------


On May 27, 2014, 12:04 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 12:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port from KIntSpinBox to QSpinBox
> 
> Unfortunately this way we cannot have a plural aware suffix.
> 
> 
> Diffs
> -----
> 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
>   klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
> 
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140529/1cffe207/attachment-0001.html>