Review Request 118382: [klipper] Fix i18n
David Edmundson
david at davidedmundson.co.uk
Thu May 29 14:20:37 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118382/#review58723
-----------------------------------------------------------
Ship it!
I'm not very happy giving a ship it to something that is ported but completely untested. We end up with code we think works, but doesn't work properly; which is worse than not touching it at all.
It should be possible to download the x-test translations? Lets ask i18n if we need to.
- David Edmundson
On May 28, 2014, 3:22 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118382/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 3:22 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> [klipper] Fix i18n
>
>
> Diffs
> -----
>
> klipper/CMakeLists.txt 7a57b30b8b59a77c3d0702095dd72bb275d22e57
> klipper/main.cpp 153a03160717431eaaa95e77903ab43de9b07fcb
>
> Diff: https://git.reviewboard.kde.org/r/118382/diff/
>
>
> Testing
> -------
>
> I still don't know how to test i18n with kf5 :-)
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140529/6a89f30a/attachment.html>
More information about the Plasma-devel
mailing list