Review Request 118376: Remove unnecessary placeholder

David Edmundson david at davidedmundson.co.uk
Wed May 28 14:24:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/
-----------------------------------------------------------

(Updated May 28, 2014, 2:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-framework


Description
-------

Remove unnecessary placeholder

Text.implicitWidth holds the size the text would be if it wasn't
truncated


+ fix wrapping of subtext
parent.preferredTextWidth was undefined, so nothing wrapped.


Diffs
-----

  src/declarativeimports/core/private/DefaultToolTip.qml 4634d74 
  tests/tooltip.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118376/diff/


Testing
-------

Added a whole new test QML file.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140528/17daab62/attachment-0001.html>


More information about the Plasma-devel mailing list