Review Request 118376: Remove unnecessary placeholder

Marco Martin notmart at gmail.com
Wed May 28 13:55:02 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118376/#review58673
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On May 28, 2014, 1:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118376/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 1:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Remove unnecessary placeholder
> 
> Text.implicitWidth holds the size the text would be if it wasn't
> truncated
> 
> 
> + fix wrapping of subtext
> parent.preferredTextWidth was undefined, so nothing wrapped.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/private/DefaultToolTip.qml 4634d74 
>   tests/tooltip.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118376/diff/
> 
> 
> Testing
> -------
> 
> Added a whole new test QML file.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140528/148713b5/attachment.html>


More information about the Plasma-devel mailing list