Review Request 118373: Do not delete passed objects to createObjectFromComponent
Commit Hook
null at kde.org
Wed May 28 10:55:58 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373/#review58646
-----------------------------------------------------------
This review has been submitted with commit a93fa67ea8072cc5c40d10b06c0e0a279bb43f02 by David Edmundson to branch master.
- Commit Hook
On May 28, 2014, 10:33 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118373/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 10:33 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> Do not delete passed objects to createObjectFromComponent
>
> Without this patch we can get a crash if createObjectFromComponent is
> called with the same component twice.
>
>
> Diffs
> -----
>
> src/kdeclarative/qmlobject.cpp 7e2a3b8
>
> Diff: https://git.reviewboard.kde.org/r/118373/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140528/c2b8688f/attachment.html>
More information about the Plasma-devel
mailing list