Review Request 118373: Do not delete passed objects to createObjectFromComponent

David Edmundson david at davidedmundson.co.uk
Wed May 28 10:33:30 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118373/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: kdeclarative


Description
-------

Do not delete passed objects to createObjectFromComponent

Without this patch we can get a crash if createObjectFromComponent is
called with the same component twice.


Diffs
-----

  src/kdeclarative/qmlobject.cpp 7e2a3b8 

Diff: https://git.reviewboard.kde.org/r/118373/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140528/9ac34b22/attachment.html>


More information about the Plasma-devel mailing list