Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
> > Ship It!
> 
> Andrew Lake wrote:
>     In case anyone is wondering why this arbitrary fellow said "Ship It!", I just wanted to provide an explicit thumbs up that this matches the 4px spacing basis grid recommended in the HIG (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We can tackle individual layout designs separately to get the spacing even better.
> 
> Christoph Feck wrote:
>     I hope no HIG ever suggest a fixed amount of pixels, but an amount relative to the font size.
> 
> Andrew Lake wrote:
>     Till we get a credible resolution-independent approach to laying out all visual elements, including typeface, pixels is probably the best guidance guidance we can come up with.

With Qt 5.4's new high DPI pixels no longer refers to actual pixels. One writes code as though the screen will be 96dpi, and Qt scales 4px to 4 or 8 or 16 real pixels depending.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
-----------------------------------------------------------


On May 27, 2014, 10:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 10:38 p.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -----
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> -------
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> ----------------
> 
> compositing_kcm
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/3baa5e86/attachment.html>