Review Request 105312: Add missing email addresses back into add widget tooltip.
Matthew Dawson
matthew at mjdsystems.ca
Tue May 27 18:27:47 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105312/
-----------------------------------------------------------
(Updated May 27, 2014, 2:27 p.m.)
Status
------
This change has been discarded.
Review request for Plasma, Ivan Čukić and Marco Martin.
Repository: kde-workspace
Description
-------
When the QML port of the add widget dialog occured, the creator's email address got chopped off. This commit fixes a bug hidding the email address, and also starts displaying it again in the tooltip.
There are a couple of issue left with this patch:
1) I have to disable wrapping, otherwise the text wraps at odd points for no reason (it fits fine otherwise).
2) The link currently doesn't work as I'm not sure how to hook it up to send mail. Should it be left as is, or just remove the link for 4.9 and update with a link for 4.10?
Diffs
-----
libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml ba804fd006496ee4a7118e97fe44038f0617eec7
libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h e745ef58533ab0e22d2109d5beeff6c29c4d18b4
Diff: https://git.reviewboard.kde.org/r/105312/diff/
Testing
-------
Tested locally in Xephyr. The tooltip now contains the email address.
Thanks,
Matthew Dawson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/d5c6648c/attachment.html>
More information about the Plasma-devel
mailing list