Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

[Martin Gräßlin]

> On May 27, 2014, 3:52 p.m., Martin Klapetek wrote:
> > > Unfortunately this way we cannot have a plural aware suffix.
> > 
> > What if you do this from code like "setSuffix(i18np("signular", "plural", value));" ?
> 
> Martin Klapetek wrote:
>     Oh but that's not a binding so it won't auto update...too much time in QML xD
>     
>     Nevermind.

I hoped there is a better solution, which I'm just not aware of :-) It would need a connect to update the suffix whenever the value changes, which was the reason I didn't implement that one.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58567
-----------------------------------------------------------


On May 27, 2014, 2:04 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port from KIntSpinBox to QSpinBox
> 
> Unfortunately this way we cannot have a plural aware suffix.
> 
> 
> Diffs
> -----
> 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
>   klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
> 
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/833aff15/attachment.html>