Review Request 118346: [klipper] Re-enable prison support

[Martin Gräßlin]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar change and backed away from it, due to no way to figure out whether prison is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely breaking klipper. To solve this I added a version check in my variant, but that's of course also incomplete.
> 
> Johannes Huber wrote:
>     This seems debian/ubuntu specific problem. Works here on Gentoo with prison qt5 build. As this is a optional build option it can be easily disabled downstream.
>     
>     * Contents of media-libs/prison-9999:
>     /usr
>     /usr/include
>     /usr/include/prison
>     /usr/include/prison/AbstractBarcode
>     /usr/include/prison/BarcodeItem
>     /usr/include/prison/BarcodeWidget
>     /usr/include/prison/Code39Barcode
>     /usr/include/prison/Code93Barcode
>     /usr/include/prison/DataMatrixBarcode
>     /usr/include/prison/QRCodeBarcode
>     /usr/include/prison/abstractbarcode.h
>     /usr/include/prison/barcodeitem.h
>     /usr/include/prison/barcodewidget.h
>     /usr/include/prison/code39barcode.h
>     /usr/include/prison/code93barcode.h
>     /usr/include/prison/datamatrixbarcode.h
>     /usr/include/prison/prison_export.h
>     /usr/include/prison/qrcodebarcode.h
>     /usr/lib
>     /usr/lib/debug
>     /usr/lib/debug/usr
>     /usr/lib/debug/usr/lib64
>     /usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
>     /usr/lib64
>     /usr/lib64/cmake
>     /usr/lib64/cmake/Prison
>     /usr/lib64/cmake/Prison/PrisonConfig.cmake
>     /usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
>     /usr/lib64/libprison.so -> libprison.so.0
>     /usr/lib64/libprison.so.0 -> libprison.so.0.2.0
>     /usr/lib64/libprison.so.0.2.0
>     
>
> 
> Martin Gräßlin wrote:
>     and what happens if you have both prison for qt4 and qt5 installed? This looks to me like you only have one install of prison.
>     
>     I run into this issue on Saturday resulting in the linked review request. To me it looks like prison for Qt 5 has not yet reached a quality that allows it as a dependency.
>     
>     Of course it's an optional dependency and can be easily disabled. But it means that anybody not yet having prison/qt5, but having a prison/qt4 will have picked it up automatically and thus breaking klipper. As long as prison doesn't fix that, it's a -2 to me. It's easy to fix in prison: just use a new version number for the Qt5 build.
> 
> Johannes Huber wrote:
>     > and what happens if you have both prison for qt4 and qt5 installed?
>     
>     
>      * package media-libs/prison-1.1.1 NOT merged
>      * 
>      * Detected file collision(s):
>      * 
>      *      /usr/include/prison/prison_export.h
>      *      /usr/include/prison/QRCodeBarcode
>      *      /usr/include/prison/qrcodebarcode.h
>      *      /usr/include/prison/DataMatrixBarcode
>      *      /usr/include/prison/datamatrixbarcode.h
>      *      /usr/include/prison/Code93Barcode
>      *      /usr/include/prison/code93barcode.h
>      *      /usr/include/prison/Code39Barcode
>      *      /usr/include/prison/code39barcode.h
>      *      /usr/include/prison/BarcodeWidget
>      *      /usr/include/prison/barcodewidget.h
>      *      /usr/include/prison/BarcodeItem
>      *      /usr/include/prison/barcodeitem.h
>      *      /usr/include/prison/AbstractBarcode
>      *      /usr/include/prison/abstractbarcode.h
>      *      /usr/lib64/cmake/Prison/PrisonConfig.cmake
>      *      /usr/lib64/libprison.so
>      *      /usr/lib64/libprison.so.0
>     
>     With the current build system of prison it isn't possible to install prison qt4/qt5 in parallel.
>
> 
> Martin Gräßlin wrote:
>     > With the current build system of prison it isn't possible to install prison qt4/qt5 in parallel.
>     
>     sorry, but we get side tracked. The issue is that if Qt 4 version is installed, but not the Qt 5 version, the Qt 4 version gets picked and breaks klipper.
> 
> Johannes Huber wrote:
>     Yes thats an downstream packaging issue of defining the correct version.

no that is NOT a packaging issue. If one has the Qt4 version installed it gets picked. No matter whether you have a Qt5 version installed or not.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
-----------------------------------------------------------


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> -----------------------------------------------------------
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Build option is needed to have prison support.
> 
> 
> Diffs
> -----
> 
>   klipper/CMakeLists.txt c700f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/118346/diff/
> 
> 
> Testing
> -------
> 
> Compiled with and without prison support. 
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140527/a424df7c/attachment-0001.html>