Review Request 118330: [klipper] Port from KUniqueApplication to QApplication + KDBusService

[Aleix Pol Gonzalez]

> On May 26, 2014, 2:04 p.m., Aleix Pol Gonzalez wrote:
> > klipper/main.cpp, line 43
> > <https://git.reviewboard.kde.org/r/118330/diff/1/?file=275099#file275099line43>
> >
> >     All these ugly calls are not needed if you use KAbout::setApplicationData(Klipper::aboutData), provided you port these to KAboutData, of course.
> 
> Martin Gräßlin wrote:
>     thanks, I didn't know that. I think they need to stay for the moment, as I need to port away from KCmdLineArgs before being able to port KAboutData. And I need to port away from KUniqueApplication before porting away from KCmdLineArgs. I don't want to do that all in one step.
> 
> Martin Gräßlin wrote:
>     adding more: that could be useful in the porting notes, as I looked at them to port from KApplication to QApplication.

Ok, if you want to do different steps, I can give you a ship it, this is a step forward anyway.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118330/#review58479
-----------------------------------------------------------


On May 26, 2014, 1:58 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118330/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 1:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port from KUniqueApplication to QApplication + KDBusService
> 
> 
> Diffs
> -----
> 
>   klipper/main.cpp 0effa8a948408fe9044135e2d8e10c58f8385ab3 
>   klipper/CMakeLists.txt c700f9e65ff54193503bfaa2bea9a56e46d5ad46 
> 
> Diff: https://git.reviewboard.kde.org/r/118330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140526/4331d7b1/attachment.html>