Review Request 118327: [klipper] Use same version number as plasma workspace in general

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118327/#review58470
-----------------------------------------------------------

Ship it!


Confirm you've tested the output please before shipping. See comment #2


klipper/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118327/#comment40673>

    Noob question. Where is this defined?



klipper/config-klipper.h.cmake
<https://git.reviewboard.kde.org/r/118327/#comment40672>

    Does this work?
    
    Syntax is normally @KLIPPER_VERSION_STRING@
    
    in cmake configure files.
    


- David Edmundson


On May 26, 2014, 12:18 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118327/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 12:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Use same version number as plasma workspace in general
> 
> 
> Diffs
> -----
> 
>   klipper/version.h 956d1c3eb6fd45d638adfd9d88e8628011279b6a 
>   klipper/klipper.cpp bc2e53dd2a8f973f4b67dd3a4ef71d8b74b52a6c 
>   klipper/config-klipper.h.cmake PRE-CREATION 
>   klipper/CMakeLists.txt 57425daeb2af29e4ab5fccb5d1afe120d258d6f7 
> 
> Diff: https://git.reviewboard.kde.org/r/118327/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140526/ca4051b3/attachment-0001.html>