Review Request 118326: [klipper] Introduce a config-klipper.h

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118326/#review58469
-----------------------------------------------------------

Ship it!



klipper/config-klipper.h.cmake
<https://git.reviewboard.kde.org/r/118326/#comment40669>

    you shouldn't need the 1 here.
    
    



klipper/klipper.h
<https://git.reviewboard.kde.org/r/118326/#comment40670>

    "" brackets would be better here, in case you also have a system installed config-klipper.h
    
    


- David Edmundson


On May 26, 2014, 12:11 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118326/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Introduce a config-klipper.h
> 
> Instead of adding the HAVE_PRISON as a define through cmake use a proper
> config-klipper.h which defines HAVE_PRISON if Prison is found.
> 
> 
> Diffs
> -----
> 
>   klipper/klipper.h 54f72ade645a825ebb8de84f2e61cbf3bdb859dc 
>   klipper/config-klipper.h.cmake PRE-CREATION 
>   klipper/CMakeLists.txt 57425daeb2af29e4ab5fccb5d1afe120d258d6f7 
> 
> Diff: https://git.reviewboard.kde.org/r/118326/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140526/7fac7f41/attachment.html>