Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118214/
-----------------------------------------------------------

(Updated May 26, 2014, 11:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
-------

[screenlocker] Pass grace time as command line argument to greeter

Instead of having the greeter read the settings of the KSLD, KSLD passes
the required values to the greeter as command line arguments. This
ensures that the greeter doesn't show a lock UI while the KSLD is still
in grace time and vice versa.

Two command line options are added:
--graceTime <milliseconds>
--endlessGrace

The option --graceTime starts the timer to show the lock ui on timeout.
The option --endlessGrace is for the case that the KSLDA never locks the
screen, thus an endless grace time.


Diffs
-----

  ksmserver/screenlocker/greeter/greeterapp.h faf6a0303154cdaeee16c370f977ef5065de61fe 
  ksmserver/screenlocker/greeter/greeterapp.cpp 60985fe86c60a5dc30bca3f0994153df188c4352 
  ksmserver/screenlocker/greeter/main.cpp 7ad58bd3ec9fcb3770292965c00e7cd06c43698b 
  ksmserver/screenlocker/ksldapp.cpp 410b3789edd7976f706fe510317a5514bf7e208d 

Diff: https://git.reviewboard.kde.org/r/118214/diff/


Testing
-------

Tested the various options.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140526/6af3d041/attachment.html>