Review Request 118214: [screenlocker] Pass grace time as command line argument to greeter

[Martin Gräßlin]

> On May 26, 2014, 12:38 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/ksldapp.cpp, line 348
> > <https://git.reviewboard.kde.org/r/118214/diff/1/?file=273576#file273576line348>
> >
> >     IMHO --nolock would be clearer than --endlessGrace.
> >     
> >     Your choice.

I agree, nolock is better, will change and push


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118214/#review58194
-----------------------------------------------------------


On May 20, 2014, 12:12 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118214/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 12:12 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [screenlocker] Pass grace time as command line argument to greeter
> 
> Instead of having the greeter read the settings of the KSLD, KSLD passes
> the required values to the greeter as command line arguments. This
> ensures that the greeter doesn't show a lock UI while the KSLD is still
> in grace time and vice versa.
> 
> Two command line options are added:
> --graceTime <milliseconds>
> --endlessGrace
> 
> The option --graceTime starts the timer to show the lock ui on timeout.
> The option --endlessGrace is for the case that the KSLDA never locks the
> screen, thus an endless grace time.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h faf6a0303154cdaeee16c370f977ef5065de61fe 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 60985fe86c60a5dc30bca3f0994153df188c4352 
>   ksmserver/screenlocker/greeter/main.cpp 7ad58bd3ec9fcb3770292965c00e7cd06c43698b 
>   ksmserver/screenlocker/ksldapp.cpp 410b3789edd7976f706fe510317a5514bf7e208d 
> 
> Diff: https://git.reviewboard.kde.org/r/118214/diff/
> 
> 
> Testing
> -------
> 
> Tested the various options.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140526/55cde044/attachment.html>