Review Request 118257: explicit dependency on kpty as needed by kdesu

Aleix Pol Gonzalez aleixpol at kde.org
Sun May 25 10:12:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118257/#review58414
-----------------------------------------------------------


This changes nothing, I don't see anything requiring KF5::Pty in kde-cli-tools.

I think the correct fix would be to add: find_dependency(KF5Pty) in KDESuConfig.cmake.

- Aleix Pol Gonzalez


On May 22, 2014, 11:23 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118257/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 11:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> explicit dependency on kpty as needed by kdesu
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fa32ecc12e9f17c1925c79729bd3aa346f75fa04 
> 
> Diff: https://git.reviewboard.kde.org/r/118257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140525/79d96344/attachment.html>


More information about the Plasma-devel mailing list