Review Request 118278: [2/2] Make sure we update the calendar on date change

Sebastian Kügler sebas at kde.org
Fri May 23 15:52:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118278/#review58360
-----------------------------------------------------------

Ship it!


Looks good. Thanks!


applets/digital-clock/package/contents/ui/CalendarView.qml
<https://git.reviewboard.kde.org/r/118278/#comment40606>

    Could be done with a Connection, adding a property just for one usage seems a bit like overkill.


- Sebastian Kügler


On May 23, 2014, 3:25 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118278/
> -----------------------------------------------------------
> 
> (Updated May 23, 2014, 3:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This part clears all the selection from the calendar when the applet hides and also binds the "today" to the dataengine.
> 
> Part 1 - https://git.reviewboard.kde.org/r/118277/
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 09a870a 
> 
> Diff: https://git.reviewboard.kde.org/r/118278/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140523/122e2b46/attachment.html>


More information about the Plasma-devel mailing list