[plasma-framework] examples/dataengines: Fix build with examples

Sebastian Kügler sebas at kde.org
Fri May 23 10:12:05 UTC 2014


CC:ing plasma-devel. Any input on this? (I just fixed the build in the most 
obvious way, perhaps someone knows why Qt5::Gui had been removed from the 
implicit public targets in the first place?

On Friday, May 23, 2014 00:54:17 Aleix Pol wrote:
> KF5::Plasma should have Qt5::Gui as public dependency, this shouldn't be
> needed.
> 
> On Mon, May 19, 2014 at 11:53 PM, Sebastian Kügler <sebas at kde.org> wrote:
> > Git commit 1f80c23bd514247d60b831de7671eff1e664d95d by Sebastian Kügler.
> > Committed on 19/05/2014 at 21:53.
> > Pushed by sebas into branch 'master'.
> > 
> > Fix build with examples
> > 
> > M  +1    -0    examples/dataengines/simpleEngine/CMakeLists.txt
> > M  +1    -0    examples/dataengines/sourcesOnRequest/CMakeLists.txt
> > 
> > 
> > http://commits.kde.org/plasma-framework/1f80c23bd514247d60b831de7671eff1e6
> > 64d95d
> > 
> > diff --git a/examples/dataengines/simpleEngine/CMakeLists.txt
> > b/examples/dataengines/simpleEngine/CMakeLists.txt
> > index 07d622d..aa8ce47 100644
> > --- a/examples/dataengines/simpleEngine/CMakeLists.txt
> > +++ b/examples/dataengines/simpleEngine/CMakeLists.txt
> > @@ -7,6 +7,7 @@ add_library(plasma_dataengine_example_simpleEngine MODULE
> > ${simpleEngine_SRCS})
> > 
> >  kservice_desktop_to_json(plasma_dataengine_example_simpleEngine
> > 
> > plasma-dataengine-example-simpleEngine.desktop)
> > 
> >  target_link_libraries(plasma_dataengine_example_simpleEngine
> > 
> > +  Qt5::Gui
> > 
> >    KF5::Plasma
> >    KF5::Service
> >    KF5::I18n
> > 
> > diff --git a/examples/dataengines/sourcesOnRequest/CMakeLists.txt
> > b/examples/dataengines/sourcesOnRequest/CMakeLists.txt
> > index c317faf..d60a8fb 100644
> > --- a/examples/dataengines/sourcesOnRequest/CMakeLists.txt
> > +++ b/examples/dataengines/sourcesOnRequest/CMakeLists.txt
> > @@ -7,6 +7,7 @@ add_library(plasma_dataengine_example_sourcesOnRequest
> > MODULE ${sourcesOnRequest
> > 
> >  kservice_desktop_to_json(plasma_dataengine_example_sourcesOnRequest
> > 
> > plasma-dataengine-example-sourcesOnRequest.desktop)
> > 
> >  target_link_libraries(plasma_dataengine_example_sourcesOnRequest
> > 
> > +  Qt5::Gui
> > 
> >    KF5::Plasma
> >    KF5::Service
> >  
> >  )

-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9


More information about the Plasma-devel mailing list