Review Request 117954: Port keditfiletype away from kde4support

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117954/
-----------------------------------------------------------

(Updated May 23, 2014, 10:45 a.m.)


Review request for Plasma and David Faure.


Changes
-------

Add David to the reviewers, to decide whether checking shared-mime-info is necessary.


Repository: kde-cli-tools


Description
-------

This patch contains multiple commits, which I can make available if needed. It ports keditfiletype away from kde4support, which helps identifying its dependencies so that it can hopefully be moved closer to the classes which need it in frameworks (right now kwidgetsaddons and kio forks it)


Diffs
-----

  CMakeLists.txt d62ee8b 
  keditfiletype/CMakeLists.txt 566e76a 
  keditfiletype/filegroupdetails.cpp c733ba4 
  keditfiletype/filetypedetails.h 7c0abb4 
  keditfiletype/filetypedetails.cpp bfcbb07 
  keditfiletype/filetypesview.h 82fd0ab 
  keditfiletype/filetypesview.cpp 886892f 
  keditfiletype/keditfiletype.h 0b235ce 
  keditfiletype/keditfiletype.cpp aab0830 
  keditfiletype/kservicelistwidget.h c817d24 
  keditfiletype/kservicelistwidget.cpp 88dface 
  keditfiletype/kserviceselectdlg.h 8e6d0d0 
  keditfiletype/kserviceselectdlg.cpp 09c7c5d 
  keditfiletype/mimetypedata.h 042b043 
  keditfiletype/mimetypedata.cpp 057113f 
  keditfiletype/mimetypewriter.h 5a618a6 
  keditfiletype/mimetypewriter.cpp be5e5d4 
  keditfiletype/newtypedlg.h fba8385 
  keditfiletype/newtypedlg.cpp c933a8f 
  keditfiletype/sharedmimeinfoversion.h 9824d7b 
  keditfiletype/sharedmimeinfoversion.cpp 9dabf0e 
  keditfiletype/tests/CMakeLists.txt 489bb4d 
  keditfiletype/tests/filetypestest.cpp 68eef26 
  keditfiletype/typeslistitem.h 05e425a 
  keditfiletype/typeslistitem.cpp 97cd3c1 

Diff: https://git.reviewboard.kde.org/r/117954/diff/


Testing
-------

Program starts and looks like it behaves correctly. Unit-test is failing, but was already failing before :/


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140523/b2f7faac/attachment-0001.html>