Review Request 118258: [klipper] Always show filter widget in klipperpopup

[Sebastian Kügler]

> On May 22, 2014, 1:23 p.m., Sebastian Kügler wrote:
> > klipper/klipperpopup.cpp, line 73
> > <https://git.reviewboard.kde.org/r/118258/diff/1/?file=274169#file274169line73>
> >
> >     Can't we use QLineEdit, in order to avoid deprecated KLineEdit?
> 
> Martin Gräßlin wrote:
>     KLineEdit is not deprecated: http://api.kde.org/frameworks-api/frameworks5-apidocs/kcompletion/html/classKLineEdit.html

Ah, okay. My bad. Thanks for the correction.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118258/#review58305
-----------------------------------------------------------


On May 22, 2014, 1:17 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118258/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 1:17 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Always show filter widget in klipperpopup
> 
> Following HIG recommendations: always show the filter widget in the
> popup with a "Search..." click message.
> 
> Given that it is no longer hidden the code could be simplified quite
> a bit.
> 
> 
> Diffs
> -----
> 
>   klipper/klipperpopup.cpp 1c9157ec4af0eaacff6de0a81b44f701bdcf79f0 
> 
> Diff: https://git.reviewboard.kde.org/r/118258/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140522/5d0fb8dc/attachment-0001.html>