Review Request 118204: [klipper] Show filter widget before sending key events to it

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118204/
-----------------------------------------------------------

(Updated May 22, 2014, 1:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

[klipper] Show filter widget before sending key events to it

Klipper is supposed to show a filter widget when starting to type.
This is done by forwarding the QKeyEvent to the not visible widget.
This seems to have broken in the Qt5 port. Instead of passing to the
widget it's send again to the KlipperPopup resulting in recursive calls
to the same method which in the end crashes Klipper.

By showing the widget before sending it the key event, everything is
fine. In case that the widget is empty after processing the key event
it gets hidden nevertheless.


Diffs
-----

  klipper/klipperpopup.cpp 574f2d7a0d0b30f94c72b2e2715778f619539a00 

Diff: https://git.reviewboard.kde.org/r/118204/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140522/44b6b011/attachment.html>