Review Request 118205: Turn the free space notifier into StatusNotifierItem

Martin Klapetek martin.klapetek at gmail.com
Tue May 20 14:17:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118205/
-----------------------------------------------------------

(Updated May 20, 2014, 4:17 p.m.)


Review request for Plasma.


Changes
-------

* Use QStringLiteral
* Use compile-time-checked signals/slots syntax


Repository: plasma-workspace


Description
-------

Currently it's done purely as a notification, which doesn't make much sense. This patch turns it into a regular SNI. The actions were moved from the notification popup to the SNI menu.


Diffs (updated)
-----

  freespacenotifier/freespacenotifier.h d3c0351 
  freespacenotifier/freespacenotifier.cpp cdf9bc5 

Diff: https://git.reviewboard.kde.org/r/118205/diff/


Testing
-------

Works properly.


File Attachments
----------------

Screenshot (fonts are broken for some reason here)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/19/a918c329-5679-4aeb-9b2e-af260c0bb4d6__fsn_sni.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140520/955620b8/attachment-0001.html>


More information about the Plasma-devel mailing list