Review Request 118199: [klipper] Call ensurePolished() before native window of menu gets created

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118199/
-----------------------------------------------------------

(Updated May 20, 2014, 5:26 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

[klipper] Call ensurePolished() before native window of menu gets created

It's important to have ensurePolished() being called before the native
XCB window gets created. The widget style (in our case Oxygen) sets the
RGBA hint during that call. Once the native window is created this would
fail.

In the case of KlipperPopup the native window gets created by accessing
the winId(), thus the ensurePolished() needs to happen before.


Diffs
-----

  klipper/klipperpopup.cpp 574f2d7a0d0b30f94c72b2e2715778f619539a00 

Diff: https://git.reviewboard.kde.org/r/118199/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140520/42b823b6/attachment.html>